Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(auth): Clean-up unused auth tokens and wipe tokens #45221

Merged
merged 1 commit into from
Aug 13, 2024
Merged

feat(auth): Clean-up unused auth tokens and wipe tokens #45221

merged 1 commit into from
Aug 13, 2024

Conversation

ChristophWurst
Copy link
Member

@ChristophWurst ChristophWurst commented May 7, 2024 •
edited
Loading

Summary

  • Kill auth tokens that have not been used in a year
  • Kill auth/session tokens marked for remote wipe more than two months ago

Checklist

@ChristophWurst ChristophWurst self-assigned this May 7, 2024
@solracsf solracsf added this to the Nextcloud 30 milestone Jun 18, 2024
This was referenced Jul 30, 2024
Merged
Merged
@Altahrim Altahrim mentioned this pull request Aug 5, 2024
Merged
@skjnldsv
Copy link
Member

skjnldsv commented Aug 6, 2024

Relevant

1) Test\Authentication\Token\PublicKeyTokenProviderTest::testInvalidateOldTokens
TypeError: Mock_IConfig_90b08448::getSystemValueInt(): Return value must be of type int, null returned

/home/runner/work/server/server/lib/private/Authentication/Token/PublicKeyTokenProvider.php:290
/home/runner/work/server/server/tests/lib/Authentication/Token/PublicKeyTokenProviderTest.php:354

@skjnldsv skjnldsv added 2. developing Work in progress and removed 3. to review Waiting for reviews labels Aug 6, 2024
@Altahrim Altahrim mentioned this pull request Aug 7, 2024
Merged
@skjnldsv skjnldsv mentioned this pull request Aug 13, 2024
Merged
@ChristophWurst ChristophWurst added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Aug 13, 2024
@ChristophWurst ChristophWurst merged commit 8bf2095 into master Aug 13, 2024
169 checks passed
@ChristophWurst ChristophWurst deleted the feat/auth/authtoken-clean-up branch August 13, 2024 14:32
@ChristophWurst ChristophWurst mentioned this pull request Aug 19, 2024
Merged
@ChristophWurst ChristophWurst added the pending documentation This pull request needs an associated documentation update label Aug 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@come-nc come-nc come-nc approved these changes

@Altahrim Altahrim Altahrim approved these changes

@nickvergessen nickvergessen nickvergessen approved these changes

@sorbaugh sorbaugh Awaiting requested review from sorbaugh

Assignees

@ChristophWurst ChristophWurst

Labels
3. to review Waiting for reviews feature: authentication pending documentation This pull request needs an associated documentation update
Projects
None yet
Milestone
Nextcloud 30
Development

Successfully merging this pull request may close these issues.
6 participants
@ChristophWurst @skjnldsv @nickvergessen @Altahrim @come-nc @solracsf